Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced windows-latest with windows-2019 to fix windows builds #1686

Merged
merged 1 commit into from
May 17, 2024
Merged

Replaced windows-latest with windows-2019 to fix windows builds #1686

merged 1 commit into from
May 17, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Based on experimentation with mkl_fft, switching from using "windows-latest" image to "windows-2019" fixes MS compiler use for Python packages.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.971%. remained the same
when pulling 541f5ae on use-windows-2019
into ee1ee10 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_2 ran successfully.
Passed: 890
Failed: 15
Skipped: 91

ndgrigorian
ndgrigorian approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows builds are working so LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 9df040a into master May 17, 2024
47 of 60 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the use-windows-2019 branch May 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian