Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'template' from call to get_kernel method of kernel bundle in sorting #1726

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Remove 'template' from call to get_kernel method of kernel bundle in sorting #1726

merged 1 commit into from
Jul 10, 2024

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jul 8, 2024 •
edited
Loading

This PR removes an unnecessary templating of the get_kernel method of the kernel bundle in sort.hpp.

As no template parameter was given, this not only did not do anything, but was causing nightly builds to fail.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Remove 'template' from call to get_kernel method of kernel bundle
a8769c6 
Was causing nightly build failure, and did nothing anyway
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.968%. remained the same
when pulling a8769c6 on remove-unnecessary-templated-method
into f3c2975 on master.

@ndgrigorian ndgrigorian marked this pull request as ready for review July 8, 2024 19:09
@ndgrigorian ndgrigorian requested a review from antonwolfy July 8, 2024 19:09
antonwolfy
antonwolfy approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndgrigorian ndgrigorian merged commit 734fd8b into master Jul 10, 2024
46 of 49 checks passed
@ndgrigorian ndgrigorian deleted the remove-unnecessary-templated-method branch July 10, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @antonwolfy