Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for gh 1738 #1741

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix for gh 1738 #1741

merged 2 commits into from
Jul 22, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Resolves gh-1738

Changes unique_all and unique_inverse to always return inverse_indices data field as array with default indexing data type.

A test added to verify this behavior.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_133 ran successfully.
Passed: 894
Failed: 15
Skipped: 105

@coveralls
Copy link
Collaborator

coveralls commented Jul 18, 2024 •
edited
Loading

Coverage Status

coverage: 87.965% (-0.001%) from 87.966%
when pulling 7e2c43c on fix-for-gh-1738
into e35dfa8 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_152 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@oleksandr-pavlyk
Resolves gh-1738
3e6c9b6 
The unique_inverse and unique_all now always return inverse_index
data fields in default indexing data type as per Python Array API
specification.
@oleksandr-pavlyk
Add test based on example provided in gh-1738
7e2c43c
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_154 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@oleksandr-pavlyk
Copy link
Collaborator Author

@antonwolfy The artifacts of conda-project workflow should have the expected NumPy pinning bracket now. Please test changes in this PR against dpnp.

antonwolfy
antonwolfy approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oleksandr-pavlyk
The issue is fully resolved now.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 28cc7bd into master Jul 22, 2024
40 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-for-gh-1738 branch July 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dpt.unique_inverse and dpt.unique_all returns inverse_indices array of int32 dtype
3 participants
@oleksandr-pavlyk @coveralls @antonwolfy