Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max dimensions to array API capabilities #1774

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

ndgrigorian
Copy link
Collaborator

This PR adds max dimensions to the dpctl.tensor.__array_namespace_info__().capabilities() dictionary.

Also revises the other keys to this dictionary, which did not align exactly with their inclusion in the specification.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Jul 31, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_190 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.609%. remained the same
when pulling a25184d on max-dimensions-inspection
into a40263d on master.

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ndgrigorian ! LGTM

@ndgrigorian ndgrigorian merged commit 1462d8c into master Jul 31, 2024
26 of 35 checks passed
@ndgrigorian ndgrigorian deleted the max-dimensions-inspection branch July 31, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants