Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with dpctl changes for DLPack v1.0 support #1980

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 12, 2024

In scope of dpctl-1667 the adaptation towards DLPack v1.0 was added in dpctl.

This PR is intended to leverage on these changes and to extend DLPack i/f to fulfill the new keywords which might be passed to dpnp.ndarray.__dlpack__ and dpnp.from_dlpack.

Also the scope of the tests is significantly increased.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the adopt-to-dlpack-v1.0 branch from 0168438 to c9d2f5b Compare August 13, 2024 12:41
@antonwolfy antonwolfy marked this pull request as ready for review August 20, 2024 16:23
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 7c8e83f into master Aug 22, 2024
40 of 46 checks passed
@antonwolfy antonwolfy deleted the adopt-to-dlpack-v1.0 branch August 22, 2024 01:41
github-actions bot added a commit that referenced this pull request Aug 22, 2024
* Adopt dpnp to DLPack v1.0

* Add more tests to cover different use cases 7c8e83f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants