Modified interbotix_slate_driver to use trossen_slate #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeschmitt-tr
requested changes
Jan 28, 2025
interbotix_ros_slate/interbotix_slate_driver/include/interbotix_slate_driver/slate_base.hpp
Outdated
Show resolved
Hide resolved
interbotix_ros_slate/interbotix_slate_driver/src/slate_base.cpp
Outdated
Show resolved
Hide resolved
interbotix_ros_slate/interbotix_slate_driver/src/slate_base.cpp
Outdated
Show resolved
Hide resolved
interbotix_ros_slate/interbotix_slate_driver/src/slate_base.cpp
Outdated
Show resolved
Hide resolved
interbotix_ros_slate/interbotix_slate_driver/src/slate_base_node.cpp
Outdated
Show resolved
Hide resolved
interbotix_ros_slate/interbotix_slate_driver/src/slate_base.cpp
Outdated
Show resolved
Hide resolved
…e_base node on init_base failure.
…e_base node on init_base failure.
…or update method.
…or update method.
lukeschmitt-tr
requested changes
Jan 28, 2025
interbotix_ros_slate/interbotix_slate_driver/src/slate_base.cpp
Outdated
Show resolved
Hide resolved
interbotix_ros_slate/interbotix_slate_driver/src/slate_base.cpp
Outdated
Show resolved
Hide resolved
…initialized anyway as it was being called in constructor. Basic typo fixes and comments.
interbotix_ros_slate/interbotix_slate_driver/src/slate_base.cpp
Outdated
Show resolved
Hide resolved
lukeschmitt-tr
added a commit
that referenced
this pull request
Jan 29, 2025
* Added new trossen_slate package and modified interbotix_slate_driver to use trossen_slate. * Modified interbotix_slate_driver to use trossen_slate. * Minor cleanup on formatting and unused variables. * Quick fix of RCLCPP logging. * Typo fix with logging. * Added COLCON_IGNORE, minor logging fixes, and added shutdown for slate_base node on init_base failure. * Added COLCON_IGNORE, minor logging fixes, and added shutdown for slate_base node on init_base failure. * Simplified CMakeLists.txt, added velocity timeout back, added timer for update method. * Simplified CMakeLists.txt, added velocity timeout back, added timer for update method. * Recursive submodule checkout * Minor formatting/comments changes. * Checked out trossen_slate submodule to most recent commit. * Added frequency parameter, removed shutdown because node isn't fully initialized anyway as it was being called in constructor. Basic typo fixes and comments. * Basic formatting on slate node * Update interbotix_ros_slate/interbotix_slate_driver/src/slate_base.cpp * Updated submodule for trossen_slate to use HTTPS URL --------- Co-authored-by: Luke Schmitt <[email protected]> Co-authored-by: lukeschmitt-tr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added trossen_slate as submodule then inherited TrossenSlate in SlateBase to use methods from trossen_slate.