Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement createPParams #190

Merged

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Aug 14, 2023

Changelog

- description: |
    Implement createPParams and begin propagating Ledger.PParams in cardano-api
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here.

If the PR fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/use-EraBasedProtocolParametersUpdate-to-create-pparams branch from 976add2 to cf4b7e4 Compare August 14, 2023 15:51
@Jimbo4350 Jimbo4350 force-pushed the jordan/use-EraBasedProtocolParametersUpdate-to-create-pparams branch 2 times, most recently from 009fa45 to 6ed438e Compare August 14, 2023 16:45
@Jimbo4350 Jimbo4350 marked this pull request as ready for review August 14, 2023 16:48
@Jimbo4350 Jimbo4350 force-pushed the jordan/use-EraBasedProtocolParametersUpdate-to-create-pparams branch 2 times, most recently from fec2318 to d6ae060 Compare August 14, 2023 16:59
@Jimbo4350 Jimbo4350 force-pushed the jordan/use-EraBasedProtocolParametersUpdate-to-create-pparams branch from d6ae060 to 0fbfa98 Compare August 14, 2023 17:31
@Jimbo4350 Jimbo4350 enabled auto-merge August 15, 2023 13:24
@Jimbo4350 Jimbo4350 disabled auto-merge August 15, 2023 13:24
@Jimbo4350 Jimbo4350 merged commit 64da51c into main Aug 15, 2023
@Jimbo4350 Jimbo4350 deleted the jordan/use-EraBasedProtocolParametersUpdate-to-create-pparams branch August 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant