Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LedgerPParams #219

Closed
wants to merge 1 commit into from
Closed

Remove LedgerPParams #219

wants to merge 1 commit into from

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Remove LedgerPParams
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

An alternative version to: #218

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

carbolymer
carbolymer commented Aug 29, 2023
View reviewed changes
cardano-api/internal/Cardano/Api/TxBody.hs
@@ -15,6 +15,7 @@
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE UndecidableInstances #-}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately because of: https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/8.6#undecidableinstances-is-pickier we would need this now for using type families in deriving clauses

@carbolymer carbolymer mentioned this pull request Aug 29, 2023
Merged
10 tasks
carbolymer
carbolymer commented Aug 29, 2023
View reviewed changes
cardano-api/internal/Cardano/Api/TxBody.hs
@@ -1763,7 +1765,9 @@ data TxBodyContent build era =
txGovernanceActions :: TxGovernanceActions era,
txVotingProcedures :: Maybe (Featured ConwayEraOnwards era (VotingProcedures era))
}
deriving (Eq, Show)

deriving instance (IsShelleyBasedEra era, Eq (Ledger.PParamsHKD Identity (ShelleyLedgerEra era))) => Eq (TxBodyContent build era)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could create type alias for ledger constraints to avoid using them in the API directly.

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Nov 20, 2023
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 60 days with no activity.

@github-actions github-actions bot closed this Jan 19, 2024
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
@carbolymer
Merge pull request #219 from input-output-hk/mgalazyn/fix/change-cons…
308522e 
…titution-to-proposal-in-txbuild

Change constitution to proposal in `transaction build`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@disassembler disassembler Awaiting requested review from disassembler

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carbolymer