Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in some deserialization error messages #243

Conversation

neilmayhew
Copy link
Contributor

Changelog

- description: |
    Fix typos in some deserialization error messages
  type:
  - bugfix

Context

"Enable" and "Unable" are phonetically very similar but have widely differing meanings.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy enabled auto-merge September 14, 2023 08:51
@smelc
Copy link
Contributor

smelc commented Sep 14, 2023

@neilmayhew> can you sign your commit?

@neilmayhew
Copy link
Contributor Author

@neilmayhew> can you sign your commit?

It is signed, actually, and my email is one of the IDs in my GPG key. I'm not sure why GitHub thinks the signature doesn't match. Perhaps I need to re-upload my key to my GitHub profile.

@neilmayhew
Copy link
Contributor Author

Yes, that was it. I needed to delete and re-upload my GPG key because the previous copy didn't include my email address as an ID.

@neilmayhew
Copy link
Contributor Author

I think auto-merge isn't smart enough to notice that my commit is now verified, so this will probably need to be merged manually.

@newhoggy newhoggy disabled auto-merge September 14, 2023 20:45
@newhoggy newhoggy added this pull request to the merge queue Sep 14, 2023
Merged via the queue into IntersectMBO:main with commit a535ea2 Sep 14, 2023
newhoggy added a commit that referenced this pull request Mar 11, 2024
…ddress-command-related-names

Rename `delegation-certificate` to `stake-delegation-certificate` only in era-based command structure
@neilmayhew neilmayhew deleted the typos-in-SerialiseAsRawBytesError-messages branch December 11, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants