-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace WithdrawalsSupportedInEra with ShelleyBasedEra #260
Merged
newhoggy
merged 1 commit into
main
from
newhoggy/replace-WithdrawalsSupportedInEra-with-ShelleyBasedEra
Sep 26, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -120,8 +120,6 @@ module Cardano.Api.TxBody ( | |
ValidityLowerBoundSupportedInEra(..), | ||
AuxScriptsSupportedInEra(..), | ||
TxExtraKeyWitnessesSupportedInEra(..), | ||
AlonzoEraOnwards(..), | ||
WithdrawalsSupportedInEra(..), | ||
TxTotalAndReturnCollateralSupportedInEra(..), | ||
|
||
-- ** Feature availability functions | ||
|
@@ -131,7 +129,6 @@ module Cardano.Api.TxBody ( | |
validityLowerBoundSupportedInEra, | ||
auxScriptsSupportedInEra, | ||
extraKeyWitnessesSupportedInEra, | ||
withdrawalsSupportedInEra, | ||
txScriptValiditySupportedInShelleyBasedEra, | ||
txScriptValiditySupportedInCardanoEra, | ||
totalAndReturnCollateralSupportedInEra, | ||
|
@@ -1058,34 +1055,6 @@ extraKeyWitnessesSupportedInEra BabbageEra = Just ExtraKeyWitnessesInBabbageEra | |
extraKeyWitnessesSupportedInEra ConwayEra = Just ExtraKeyWitnessesInConwayEra | ||
|
||
|
||
-- | A representation of whether the era supports withdrawals from reward | ||
-- accounts. | ||
-- | ||
-- The Shelley and subsequent eras support stake addresses, their associated | ||
-- reward accounts and support for withdrawals from them. | ||
-- | ||
data WithdrawalsSupportedInEra era where | ||
|
||
WithdrawalsInShelleyEra :: WithdrawalsSupportedInEra ShelleyEra | ||
WithdrawalsInAllegraEra :: WithdrawalsSupportedInEra AllegraEra | ||
WithdrawalsInMaryEra :: WithdrawalsSupportedInEra MaryEra | ||
WithdrawalsInAlonzoEra :: WithdrawalsSupportedInEra AlonzoEra | ||
WithdrawalsInBabbageEra :: WithdrawalsSupportedInEra BabbageEra | ||
WithdrawalsInConwayEra :: WithdrawalsSupportedInEra ConwayEra | ||
|
||
deriving instance Eq (WithdrawalsSupportedInEra era) | ||
deriving instance Show (WithdrawalsSupportedInEra era) | ||
|
||
withdrawalsSupportedInEra :: CardanoEra era | ||
-> Maybe (WithdrawalsSupportedInEra era) | ||
withdrawalsSupportedInEra ByronEra = Nothing | ||
withdrawalsSupportedInEra ShelleyEra = Just WithdrawalsInShelleyEra | ||
withdrawalsSupportedInEra AllegraEra = Just WithdrawalsInAllegraEra | ||
withdrawalsSupportedInEra MaryEra = Just WithdrawalsInMaryEra | ||
withdrawalsSupportedInEra AlonzoEra = Just WithdrawalsInAlonzoEra | ||
withdrawalsSupportedInEra BabbageEra = Just WithdrawalsInBabbageEra | ||
withdrawalsSupportedInEra ConwayEra = Just WithdrawalsInConwayEra | ||
|
||
-- ---------------------------------------------------------------------------- | ||
-- Building vs viewing transactions | ||
-- | ||
|
@@ -1454,12 +1423,13 @@ deriving instance Show (TxExtraKeyWitnesses era) | |
|
||
data TxWithdrawals build era where | ||
|
||
TxWithdrawalsNone :: TxWithdrawals build era | ||
TxWithdrawalsNone | ||
:: TxWithdrawals build era | ||
|
||
TxWithdrawals :: WithdrawalsSupportedInEra era | ||
-> [(StakeAddress, Lovelace, | ||
BuildTxWith build (Witness WitCtxStake era))] | ||
-> TxWithdrawals build era | ||
TxWithdrawals | ||
:: ShelleyBasedEra era | ||
-> [(StakeAddress, Lovelace, BuildTxWith build (Witness WitCtxStake era))] | ||
-> TxWithdrawals build era | ||
|
||
deriving instance Eq (TxWithdrawals build era) | ||
deriving instance Show (TxWithdrawals build era) | ||
|
@@ -2905,50 +2875,11 @@ fromLedgerTxWithdrawals | |
-> Ledger.TxBody (ShelleyLedgerEra era) | ||
-> TxWithdrawals ViewTx era | ||
fromLedgerTxWithdrawals sbe body = | ||
case sbe of | ||
ShelleyBasedEraShelley | ||
| null (L.unWithdrawals withdrawals) -> TxWithdrawalsNone | ||
| otherwise -> | ||
TxWithdrawals WithdrawalsInShelleyEra $ | ||
fromShelleyWithdrawal withdrawals | ||
where | ||
withdrawals = body ^. L.withdrawalsTxBodyL | ||
|
||
ShelleyBasedEraAllegra | ||
| null (L.unWithdrawals withdrawals) -> TxWithdrawalsNone | ||
| otherwise -> | ||
TxWithdrawals WithdrawalsInAllegraEra $ | ||
fromShelleyWithdrawal withdrawals | ||
where | ||
withdrawals = body ^. L.withdrawalsTxBodyL | ||
|
||
ShelleyBasedEraMary | ||
| null (L.unWithdrawals withdrawals) -> TxWithdrawalsNone | ||
| otherwise -> | ||
TxWithdrawals WithdrawalsInMaryEra $ fromShelleyWithdrawal withdrawals | ||
where | ||
withdrawals = body ^. L.withdrawalsTxBodyL | ||
|
||
ShelleyBasedEraAlonzo | ||
| null (L.unWithdrawals withdrawals) -> TxWithdrawalsNone | ||
| otherwise -> | ||
TxWithdrawals WithdrawalsInAlonzoEra $ fromShelleyWithdrawal withdrawals | ||
where | ||
withdrawals = body ^. L.withdrawalsTxBodyL | ||
|
||
ShelleyBasedEraBabbage | ||
| null (L.unWithdrawals withdrawals) -> TxWithdrawalsNone | ||
| otherwise -> | ||
TxWithdrawals WithdrawalsInBabbageEra $ fromShelleyWithdrawal withdrawals | ||
where | ||
withdrawals = body ^. L.withdrawalsTxBodyL | ||
|
||
ShelleyBasedEraConway | ||
| null (L.unWithdrawals withdrawals) -> TxWithdrawalsNone | ||
| otherwise -> | ||
TxWithdrawals WithdrawalsInConwayEra $ fromShelleyWithdrawal withdrawals | ||
where | ||
withdrawals = body ^. L.withdrawalsTxBodyL | ||
shelleyBasedEraConstraints sbe $ | ||
let withdrawals = body ^. L.withdrawalsTxBodyL in | ||
if null (L.unWithdrawals withdrawals) | ||
then TxWithdrawalsNone | ||
else TxWithdrawals sbe $ fromShelleyWithdrawal withdrawals | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simplified with |
||
|
||
fromLedgerTxCertificates | ||
:: ShelleyBasedEra era | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍