Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TxScriptValiditySupportedInEra #261

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Sep 22, 2023

Changelog

- description: |
    Replace `TxScriptValiditySupportedInEra`.  Use AlonzoEraOnwards instead.
    Delete `txScriptValiditySupportedInCardanoEra`. Use `forEraInEra` instead.
    Delete `txScriptValiditySupportedInShelleyBasedEra`. Use `forEraInEra` instead.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Depends on #254

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/replace-TxScriptValiditySupportedInEra branch 3 times, most recently from 6ea6fa4 to b53e30f Compare September 26, 2023 10:44
@newhoggy newhoggy marked this pull request as ready for review September 26, 2023 10:45
@newhoggy newhoggy force-pushed the newhoggy/replace-TxScriptValiditySupportedInEra branch from b53e30f to 9010cf9 Compare September 28, 2023 07:06
@newhoggy newhoggy force-pushed the newhoggy/replace-TxScriptValiditySupportedInEra branch from 9010cf9 to 77a6044 Compare September 28, 2023 09:53
@newhoggy newhoggy force-pushed the newhoggy/replace-TxScriptValiditySupportedInEra branch from 77a6044 to 4e9be27 Compare September 28, 2023 10:56
@newhoggy newhoggy added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 28, 2023
@newhoggy newhoggy added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 9f54d2a Sep 28, 2023
@newhoggy newhoggy deleted the newhoggy/replace-TxScriptValiditySupportedInEra branch September 28, 2023 17:21
newhoggy added a commit that referenced this pull request Mar 11, 2024
…tion-certificate-command

New `stake-address vote-delegation-certificate` command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants