Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize AnyEraInEon. Add AnyEon #287

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Sep 29, 2023

Changelog

- description: |
    Parameterize `AnyEraInEon`. Add `AnyEon`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Allows 1-1 replacement after #280
A prerequisite for propagating ledger changes into CLI.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer marked this pull request as draft September 29, 2023 17:17
@carbolymer carbolymer marked this pull request as ready for review September 29, 2023 18:14
@carbolymer carbolymer force-pushed the mgalazyn/feature/parametereize-anyeraineon branch from 348c520 to 0e8d517 Compare September 29, 2023 18:16

data AnyEraInEon where
data AnyEraInEon eon where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show where this is being used in the cli?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbolymer carbolymer force-pushed the mgalazyn/feature/parametereize-anyeraineon branch from 0e8d517 to 9e4560b Compare September 29, 2023 19:41
@newhoggy newhoggy added this pull request to the merge queue Sep 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 30, 2023
@newhoggy newhoggy added this pull request to the merge queue Sep 30, 2023
Merged via the queue into main with commit 7d3cab6 Sep 30, 2023
@newhoggy newhoggy deleted the mgalazyn/feature/parametereize-anyeraineon branch September 30, 2023 11:58
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants