Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DRep reg certificate anchor types from cardano-cli to cardano-api #305

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 6, 2023

Changelog

- description: |
    Introduce anchor newtypes for drep registration certificate
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Contributes to fixing #301

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • NA New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/add-drep-certificate-anchor-types branch from 5082207 to 17eee55 Compare October 6, 2023 16:02
@smelc smelc marked this pull request as ready for review October 9, 2023 09:18
cardano-api/internal/Cardano/Api/Anchor.hs Outdated Show resolved Hide resolved
@smelc smelc force-pushed the smelc/add-drep-certificate-anchor-types branch from 17eee55 to 7455096 Compare October 9, 2023 18:53
@smelc smelc enabled auto-merge October 9, 2023 18:53
@smelc smelc added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 38b33a3 Oct 9, 2023
@smelc smelc deleted the smelc/add-drep-certificate-anchor-types branch October 9, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants