-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Pretty
for rendering errors instead of Show
#370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
557c682
to
121e558
Compare
carbolymer
reviewed
Nov 15, 2023
carbolymer
reviewed
Nov 15, 2023
carbolymer
reviewed
Nov 15, 2023
carbolymer
reviewed
Nov 15, 2023
carbolymer
reviewed
Nov 15, 2023
carbolymer
reviewed
Nov 15, 2023
carbolymer
reviewed
Nov 15, 2023
carbolymer
reviewed
Nov 15, 2023
carbolymer
reviewed
Nov 15, 2023
carbolymer
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change, but I have a few remarks.
121e558
to
b8d1760
Compare
b8d1760
to
559978e
Compare
carbolymer
approved these changes
Nov 16, 2023
Jimbo4350
approved these changes
Nov 16, 2023
newhoggy
pushed a commit
that referenced
this pull request
Mar 11, 2024
…ution-hash Remove eras' constitution-hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Pretty
is a typeclass from theprettyprinter
package.It has support for powerful formatting options such as colour and layout.
By switching to
Pretty
we are able to use these features. Furthermore,plutus
errors and types havePretty
instances so can utilise that to pretty print their error messages in an ergonomic way.This package is also used by
optparse-applicative
which means it is already a dependency.Pretty
also doesn't suffer the problem withShow
where many of the instances render strings that are not friendly to users.Ledger also have
Show
instances that may not behave the way we want.Our
Pretty
instances can help us break away from this status quo.In order to minimise change, this PR does not utilise these features.
Instead, it preserves formatting of all errors exactly as before leaving future PRs to tidy up the formatting and layout of our rendered errors.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist