Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support constructing DRep update certificates #421

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

carlhammann
Copy link
Contributor

@carlhammann carlhammann commented Jan 8, 2024

Changelog

- description: |
    Support constructing DRep update certificates
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This goes towards solving this issue on the cardano-cli, which already has an open PR here.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carlhammann carlhammann force-pushed the ch/support-drep-update branch 2 times, most recently from 68c34ce to a3b8441 Compare January 8, 2024 19:36
@smelc smelc force-pushed the ch/support-drep-update branch 2 times, most recently from 5e779ad to 77d7b6a Compare February 7, 2024 09:21
@smelc
Copy link
Contributor

smelc commented Feb 7, 2024

Took the only commit on my sole authorship, because I couldn't sign it for Carl when rebasing 🙃

@smelc smelc enabled auto-merge February 7, 2024 09:22
@smelc smelc force-pushed the ch/support-drep-update branch from 77d7b6a to 4607fb5 Compare February 7, 2024 10:42
@smelc smelc added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 2119697 Feb 7, 2024
21 checks passed
@smelc smelc deleted the ch/support-drep-update branch February 7, 2024 11:13
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…fidence_action_golden

Add golden test for `governance action create-no-confidence`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants