Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose default genesis for Conway and Alonzo, and DRepState constructors #482

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Expose default genesis for Conway and Alonzo, and DRepState constructors #482

merged 2 commits into from
Mar 13, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Mar 12, 2024

Changelog

- description: |
    Exported more realistic default genesis for both Conway and Alonzo, and export DRepState constructors.
  type:
  - improvement

Context

This is necessary to support the introduction of delegation and registration of DReps in cardano-cli without having to make cardano-cli depend on the ledger directly again.

This PR supports this PR in cardano-cli. Maybe a good idea to review both together.

How to trust this PR

Maybe have a look at the things exported and the default instances created.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added enhancement New feature or request conway-integration labels Mar 12, 2024
@palas palas self-assigned this Mar 12, 2024
@palas palas mentioned this pull request Mar 12, 2024
Merged
3 tasks
@palas palas marked this pull request as ready for review March 12, 2024 02:17
@palas palas force-pushed the create-testnet-data-dreg branch from a7b0a65 to bcbfe9b Compare March 12, 2024 19:49
@palas palas requested a review from carbolymer March 12, 2024 19:55
@palas palas force-pushed the create-testnet-data-dreg branch 2 times, most recently from 35b8d94 to 053faf2 Compare March 13, 2024 02:37
carbolymer
carbolymer approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

palas and others added 2 commits March 13, 2024 16:58
@palas
Expose default genesis for Conway and Alonzo, and DRepState constructors
6e99971 
- Improve Conway's default genesis
- Add and export default for Alonzo genesis
- Re-export ConwayGenesis constructors
- Re-export DRepState constructors
@palas @carbolymer
Apply suggestions from code review
9a43843 
Co-authored-by: Mateusz Galazyn <[email protected]>
@palas palas force-pushed the create-testnet-data-dreg branch from 053faf2 to 9a43843 Compare March 13, 2024 15:59
@palas palas enabled auto-merge March 13, 2024 16:00
@palas palas added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit d77f096 Mar 13, 2024
23 checks passed
@palas palas deleted the create-testnet-data-dreg branch March 13, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels
conway-integration enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palas @carbolymer