Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose UpgradeConwayPParams #485

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Expose UpgradeConwayPParams #485

merged 1 commit into from
Mar 15, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Mar 14, 2024

Changelog

- description: |
    Exposed `UpgradeConwayPParams` constructors and type.
# uncomment types applicable to the change:
  type:
  - improvement    # QoL changes e.g. refactoring

Context

Required by #646

How to trust this PR

It affects two lines, so it shouldn't be problematic.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Mar 14, 2024
@palas palas self-assigned this Mar 14, 2024
@palas palas enabled auto-merge March 14, 2024 19:21
@palas palas force-pushed the expose-upgrade-conway branch from b402952 to 9560e45 Compare March 14, 2024 19:22
@palas palas mentioned this pull request Mar 14, 2024
Merged
3 tasks
@palas palas added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 3cd376f Mar 15, 2024
23 checks passed
@palas palas deleted the expose-upgrade-conway branch March 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palas @carbolymer