Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shelley: export {to,from}AlonzoLanguage (Plutus script language conversions) #731

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 20, 2025

Changelog

- description: |
    Shelley: export {to,from}AlonzoLanguage (Plutus script language conversions)
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Required to adapt cardano-node to #729

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

Comment on lines +140 to +141
, toAlonzoLanguage
, fromAlonzoLanguage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should replace those two function with Inject instances.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbolymer> I disagree, I think we should keep Inject for conversions between eons; otherwise upon seeing a call to inject in the code we won't easily know what it's about.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what is Inject for in general. It's used widely in ledger codebase for conversion between isomorphic types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbolymer> is the ledger a model codebase in terms of ease-of-understanding 😉?

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smelc smelc added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 20, 2025
@smelc smelc force-pushed the smelc/additional-language-exports branch from 49f3ce6 to 2430f57 Compare January 20, 2025 21:06
@smelc smelc enabled auto-merge January 20, 2025 21:07
@smelc smelc added this pull request to the merge queue Jan 20, 2025
Merged via the queue into master with commit 21e9ab8 Jan 20, 2025
28 of 29 checks passed
@smelc smelc deleted the smelc/additional-language-exports branch January 20, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants