Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cardano-ledger-1.3 #97

Merged
merged 7 commits into from
Jul 5, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Jul 4, 2023

Changelog

- description: |
    Propagate ledger's TxCert type family throughout the api 
  compatibility: breaking
  type: feature

Context

Upgrade to cardano-ledger-1.3 which introduced TxCert era and requires integration with Certificate era.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy changed the title Newhoggy/upgrade to cardano ledger 1.3 Upgrade to cardano-ledger-1.3 Jul 4, 2023
@Jimbo4350 Jimbo4350 force-pushed the newhoggy/upgrade-to-cardano-ledger-1.3 branch 2 times, most recently from b798a66 to f2edd5d Compare July 4, 2023 16:49
@Jimbo4350 Jimbo4350 marked this pull request as ready for review July 4, 2023 16:54
@Jimbo4350 Jimbo4350 force-pushed the newhoggy/upgrade-to-cardano-ledger-1.3 branch 3 times, most recently from 9dcf5ce to a524fde Compare July 4, 2023 17:56
@Jimbo4350 Jimbo4350 force-pushed the newhoggy/upgrade-to-cardano-ledger-1.3 branch from a524fde to 43e47a9 Compare July 4, 2023 18:14
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Jul 5, 2023
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Jul 5, 2023
@carbolymer carbolymer enabled auto-merge July 5, 2023 11:24
@carbolymer carbolymer added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit ea56e4e Jul 5, 2023
@carbolymer carbolymer deleted the newhoggy/upgrade-to-cardano-ledger-1.3 branch July 5, 2023 12:15
@erikd erikd mentioned this pull request Jul 6, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants