Remove semaphores and disable parallel test execution for GHA #1062
+94
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
requested review from
a team,
Jimbo4350,
newhoggy,
carbolymer,
smelc,
kevinhammond and
disassembler
as code owners
carbolymer
reviewed
Feb 10, 2025
carbolymer
approved these changes
Feb 10, 2025
smelc
approved these changes
Feb 11, 2025
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-test/Test/Cli/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
Jimbo4350
approved these changes
Feb 11, 2025
palas
force-pushed
the
remove-semaphores-and-parallelism
branch
from
d392765 to
f115e7a
Compare
Co-authored-by: Clément Hurlin <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Semaphores complicate code, and they seem to only be needed for GHA. At the same time parallel test execution saves very little time. So this PR disables parallel test execution for GHA, and it removes all usages of semaphores in tests.
How to trust this PR
Check parallel test execution is properly disabled in GHA, that it doesn't need disabling anywhere else. And that modifications didn't break anything.
Checklist