Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote create: support DRep and CC script hash #665

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Mar 20, 2024

Changelog

- description: |
    vote create: support DRep and CC script hash
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #661

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@CarlosLopezDeLara
Copy link
Contributor

Perfect!

Vote with Drep script hash

{[3, h'4A94737ECAA3238D7CAF94B87FC52D07FE978823D6D16C06F1163214']: {[h'66696EF1110A8F6574814DB66112CBEAFAA9C045143790278931D3AF6DBA3F41', 0]: [1, null]}}

Vote with CC hot script hash

{[1, h'4A94737ECAA3238D7CAF94B87FC52D07FE978823D6D16C06F1163214']: {[h'66696EF1110A8F6574814DB66112CBEAFAA9C045143790278931D3AF6DBA3F41', 0]: [1, null]}}

1 similar comment
@CarlosLopezDeLara
Copy link
Contributor

Perfect!

Vote with Drep script hash

{[3, h'4A94737ECAA3238D7CAF94B87FC52D07FE978823D6D16C06F1163214']: {[h'66696EF1110A8F6574814DB66112CBEAFAA9C045143790278931D3AF6DBA3F41', 0]: [1, null]}}

Vote with CC hot script hash

{[1, h'4A94737ECAA3238D7CAF94B87FC52D07FE978823D6D16C06F1163214']: {[h'66696EF1110A8F6574814DB66112CBEAFAA9C045143790278931D3AF6DBA3F41', 0]: [1, null]}}

]
pScriptHash
"constitution-script-hash"
"Constitution script hash (hex-encoded). Obtain it with \"cardano-cli conway governance hash script ...\"."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conway governance hash anchor-data...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarlosLopezDeLara> I'm not sure what you mean. This help text seems correct (it is about the hash of a script).

@smelc smelc force-pushed the smelc/voting-script-cc-dreps branch from 17eecd4 to c981331 Compare March 21, 2024 08:32
@smelc smelc marked this pull request as ready for review March 21, 2024 09:21
@carbolymer
Copy link
Contributor

Can you squash commits and improve their descriptions?

@smelc smelc force-pushed the smelc/voting-script-cc-dreps branch from c981331 to 921db76 Compare March 21, 2024 09:40
@smelc
Copy link
Contributor Author

smelc commented Mar 21, 2024

Can you squash commits and improve their descriptions?

@carbolymer> done 👍

@smelc smelc enabled auto-merge March 21, 2024 09:41
@smelc smelc added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 8def78a Mar 21, 2024
17 checks passed
@smelc smelc deleted the smelc/voting-script-cc-dreps branch March 21, 2024 10:00
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voting for script based CC members and script based DReps
4 participants