Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable both --cold-script-file and --cold-script-hash for committee auth and resig commands #699

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Apr 5, 2024

Changelog

- description: |
    Enable both `--cold-script-file` and `--cold-script-hash` for `governance committee create-hot-key-authorization-certificate` and `committee create-cold-key-resignation-certificate`
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

na

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

cardano-cli/src/Cardano/CLI/Types/Key.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Types/Key.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carbolymer carbolymer force-pushed the mgalazyn/feature/make-script-hash-file-available-for-committee-auth-resig branch 2 times, most recently from a938b13 to 14176e0 Compare April 8, 2024 18:33
@carbolymer carbolymer force-pushed the mgalazyn/feature/make-script-hash-file-available-for-committee-auth-resig branch from 14176e0 to a7a2277 Compare April 8, 2024 18:59
@carbolymer carbolymer enabled auto-merge April 8, 2024 19:00
@carbolymer carbolymer added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 210a5f1 Apr 8, 2024
16 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/make-script-hash-file-available-for-committee-auth-resig branch April 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants