action create-hardfork cmd + update description fields in all governance action files.

[CarlosLopezDeLara]

Changelog

- description: |
    Introduces the `governance action create-hardfork` cmd.
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Closes #721

How to trust this PR

Run the command

cardano-cli conway governance action create-hardfork \
--mainnet \
--anchor-url example.com \
--anchor-data-hash c7ddb5b493faa4d3d2d679847740bdce0c5d358d56f9b1470ca67f5652a02745 \
--deposit-return-stake-verification-key-file stake.vkey \
--governance-action-deposit 12345 \
--protocol-major-version 10 \
--protocol-minor-version 0 \
--out-file conway-create-hardfork.action

Explore the text envelope en check it with cbor.me

{
    "type": "Governance proposal",
    "description": "Hardfork initiation governance action",
    "cborHex": "84193039581de18f4a3466a404c11eb410313015b88e447d81b60089e25f611600e6058301f6820a00826b6578616d706c652e636f6d5820c7ddb5b493faa4d3d2d679847740bdce0c5d358d56f9b1470ca67f5652a02745"
}

[12345, h'E18F4A3466A404C11EB410313015B88E447D81B60089E25F611600E605', [1, null, [10, 0]], ["example.com", h'C7DDB5B493FAA4D3D2D679847740BDCE0C5D358D56F9B1470CA67F5652A02745']]

or with

cardano-cli conway governance action view --action-file conway-create-hardfork.action
{
    "anchor": {
        "dataHash": "c7ddb5b493faa4d3d2d679847740bdce0c5d358d56f9b1470ca67f5652a02745",
        "url": "example.com"
    },
    "deposit": 12345,
    "governance action": {
        "contents": [
            null,
            {
                "major": 10,
                "minor": 0
            }
        ],
        "tag": "HardForkInitiation"
    },
    "return address": {
        "credential": {
            "keyHash": "8f4a3466a404c11eb410313015b88e447d81b60089e25f611600e605"
        },
        "network": "Mainnet"
    }
}

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[carbolymer]

LGTM, nice job! Can you add a test for that, similarly to the other ones here: https://github.com/IntersectMBO/cardano-cli/blob/main/cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/Action.hs

[carbolymer]

The windows CI failure: IntersectMBO/cardano-node#5811 (comment) - we can ignore windows GHA, it's fixed in nix already.

[smelc]

LGTM 🍾 A few typos in the help needs fixing.

[Jimbo4350]

LGTM! Feel free to merge after @smelc approves.

[Jimbo4350]

The commit history needs to be cleaned up. Squashing commits and leaving a commit message like:

Squashed commit of the following:

commit https://github.com/IntersectMBO/cardano-cli/commit/82cc5c1ab7ff50d4072a4e4dea0ba9f6665e04be
Merge: https://github.com/IntersectMBO/cardano-cli/commit/8229fc0c0e3d07f26f1c0707893cf5544746e115 https://github.com/IntersectMBO/cardano-cli/commit/e3dc0a02ffdcd44779a7a7dac99d68d1cc235bdc
Author: Carlos LopezDeLara <[email protected]>
Date:   Thu May 2 13:10:52 2024 -0600

    Merge branch 'cl/hardforkinit' of github.com:IntersectMBO/cardano-cli into cl/hardforkinit

commit https://github.com/IntersectMBO/cardano-cli/commit/8229fc0c0e3d07f26f1c0707893cf5544746e115
Author: Carlos LopezDeLara <[email protected]>
Date:   Wed May 1 12:09:49 2024 -0600

    action create-hardfork command

    Co-Authored-By: Clément Hurlin <[email protected]>

commit https://github.com/IntersectMBO/cardano-cli/commit/e3dc0a02ffdcd44779a7a7dac99d68d1cc235bdc
Author: Carlos LopezDeLara <[email protected]>
Date:   Wed May 1 12:09:49 2024 -0600

    action create-hardfork command

    Co-Authored-By: Clément Hurlin <[email protected]>

@CarlosLopezDeLara

is not very readable. When you squash commits you need to summarize the changes in those commits in a concise and clear manner.

I also don't know what is happening in 3d8a21f4792c0983b94f493ee064a3203a1c86da.

[smelc]

@CarlosLopezDeLara> those commits should not be here:

Since they have been merged already. I can help you clean this up during our pair programming session 👍

[Jimbo4350]

LGTM!