Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create toJSON instance for "query drep-state" output #863

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Aug 8, 2024

Changelog

- description: |
    Create toJSON instance for `query drep-state` output. Haskell users can know use this type to parse back `query drep-state`'s output to a Haskell value automatically.
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #606

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/drep-state-output-json-instance branch from 07b7543 to 6bc8e88 Compare August 8, 2024 10:19
@smelc smelc marked this pull request as ready for review August 8, 2024 10:47
@smelc smelc force-pushed the smelc/drep-state-output-json-instance branch from 6bc8e88 to 2a2986f Compare August 12, 2024 08:18
@smelc smelc added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 12, 2024
@smelc smelc merged commit 08d89d1 into main Aug 13, 2024
25 checks passed
@smelc smelc deleted the smelc/drep-state-output-json-instance branch August 13, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ToJSON instance for output of drep-state
2 participants