Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI action for Cicero #1280

Merged
merged 5 commits into from
Feb 24, 2023
Merged

add CI action for Cicero #1280

merged 5 commits into from
Feb 24, 2023

Conversation

dermetfan
Copy link
Contributor

@dermetfan dermetfan commented Oct 10, 2022

This adds a Cicero action that runs all hydra jobs on pushes and pull requests.
Also purified nix evaluation of hydra jobs.

@dermetfan dermetfan added the help wanted Extra attention is needed label Oct 10, 2022
@dermetfan dermetfan force-pushed the cicero branch 2 times, most recently from 93e519c to 2cfc58a Compare October 10, 2022 18:52
@dermetfan dermetfan removed the help wanted Extra attention is needed label Oct 10, 2022
@dermetfan dermetfan force-pushed the cicero branch 2 times, most recently from 29de99d to 976d6a5 Compare October 11, 2022 08:20
@dermetfan dermetfan marked this pull request as ready for review October 11, 2022 08:21
@dermetfan dermetfan requested review from a team and kderme as code owners October 11, 2022 08:21
cabal.project Outdated Show resolved Hide resolved
iohk-bors bot added a commit to IntersectMBO/cardano-node that referenced this pull request Nov 10, 2022
4518: fix nix impurity r=dermetfan a=dermetfan

`builtins.currentSystem` is not available in pure evaluation.

Discovered while working on IntersectMBO/cardano-db-sync#1280.

Co-authored-by: Robin Stumm <[email protected]>
@dermetfan dermetfan force-pushed the cicero branch 5 times, most recently from 76e328a to 697a995 Compare November 17, 2022 16:43
@dermetfan dermetfan marked this pull request as draft November 17, 2022 17:08
@dermetfan dermetfan force-pushed the cicero branch 6 times, most recently from db06300 to 08a9720 Compare November 18, 2022 09:51
@dermetfan dermetfan marked this pull request as ready for review November 18, 2022 09:54
@kderme
Copy link
Contributor

kderme commented Jan 17, 2023

@dermetfan is this finalised? Does it require a rebase or a review from @input-output-hk/devops

@dermetfan dermetfan force-pushed the cicero branch 2 times, most recently from 4487b4f to 68a5bfa Compare January 31, 2023 17:39
@dermetfan
Copy link
Contributor Author

Cicero reports this error for nix build .#ciJobs.x86_64-linux.required which is equivalent to nix build required -f release.nix on current master:

error: A definition for option `services.cardano-db-sync.socketPath' is not of type `null or (path)'. Definition values:
       - In `/nix/store/xxs457ajxj8fjm2shjmik6mdz2spyjzy-source/nixos/lib/build-vms.nix': <function>

As it fails with the same message on master as well I would say CI is doing its job and this is ready to merge. @kderme

iohk-bors bot added a commit that referenced this pull request Feb 23, 2023
1280: add CI action for Cicero r=jbgi a=dermetfan

This adds a Cicero action that runs all hydra jobs on pushes and pull requests.
Also purified nix evaluation of hydra jobs.

Co-authored-by: Robin Stumm <[email protected]>
Co-authored-by: Jean-Baptiste Giraudeau <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 23, 2023

Timed out.

@jbgi jbgi force-pushed the cicero branch 5 times, most recently from bf4df71 to d5d70ce Compare February 24, 2023 12:42
@jbgi
Copy link
Contributor

jbgi commented Feb 24, 2023

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 24, 2023

👎 Rejected by too few approved reviews

Copy link
Contributor

@kderme kderme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re cabal.project changes

@jbgi
Copy link
Contributor

jbgi commented Feb 24, 2023

bors r+

@jbgi
Copy link
Contributor

jbgi commented Feb 24, 2023

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 24, 2023

Canceled.

@jbgi
Copy link
Contributor

jbgi commented Feb 24, 2023

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 24, 2023
1280: add CI action for Cicero r=jbgi a=dermetfan

This adds a Cicero action that runs all hydra jobs on pushes and pull requests.
Also purified nix evaluation of hydra jobs.

Co-authored-by: Robin Stumm <[email protected]>
Co-authored-by: Jean-Baptiste Giraudeau <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 24, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from input-output-hk/docs-access. 3 of 4 required status checks are expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@jbgi
Copy link
Contributor

jbgi commented Feb 24, 2023

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 24, 2023
1280: add CI action for Cicero r=jbgi a=dermetfan

This adds a Cicero action that runs all hydra jobs on pushes and pull requests.
Also purified nix evaluation of hydra jobs.

Co-authored-by: Robin Stumm <[email protected]>
Co-authored-by: Jean-Baptiste Giraudeau <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 24, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"3 of 4 required status checks are expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@jbgi
Copy link
Contributor

jbgi commented Feb 24, 2023

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 24, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 8981a96 into master Feb 24, 2023
@iohk-bors iohk-bors bot deleted the cicero branch February 24, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants