Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync formal spec and implementation in EPOCH rule #1687

Merged
merged 1 commit into from
Jul 21, 2020
Merged

sync formal spec and implementation in EPOCH rule #1687

merged 1 commit into from
Jul 21, 2020

Conversation

JaredCorduan
Copy link
Contributor

  • add validation to the shelley genesis config for the Quorum being greater than half the number of genesis nodes
  • rename votedValuePParams in implementation to match spec, ie votedValue
  • perform the union override right on the new protocol parameters inside votedValue in the formal spec (as done in the impl).
  • rename ppup to pup in EPOCH rule.
  • obtain the pup from utxoState', not utxoState, in the EPOCH rule.
  • add some comments explaining the votedValue function.

closes #1685

sync formal spec and implementation in EPOCH rule
ace0ce1 
also adding a check for the quorum constant
no semantic changes

see github issue #1685
@JaredCorduan JaredCorduan requested a review from uroboros as a code owner July 20, 2020 20:10
uroboros
uroboros approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@uroboros uroboros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JaredCorduan JaredCorduan merged commit b67a3b3 into master Jul 21, 2020
@iohk-bors iohk-bors bot deleted the jc/audit-1685 branch July 21, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uroboros uroboros uroboros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Epoch Transition Formal Spec <-> Executable Spec Discrepancies
2 participants
@JaredCorduan @uroboros