Proper Compactible instance for Value #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
reviewed
Nov 18, 2020
|
|
||
| data CVPart era | ||
| = CVPart | ||
| (PolicyID era) |
There was a problem hiding this comment.
Maybe unrelated to this PR, but does PolicyID really need to be parameterised over the era? The crypto should be enough, right?
newtype PolicyID era = PolicyID {policyID :: ScriptHash era}
newtype ScriptHash era
= ScriptHash (Hash.Hash (ADDRHASH (Crypto era)) (Core.Script era))You could apply the EraIndependentTxBody trick here too?
There was a problem hiding this comment.
yes, crypto should be enough, I do think the EraIndependentTxBody trick would make this better. (I'd probably do this in a separate PR)
|
|
||
| data CVPart era | ||
| = CVPart | ||
| (PolicyID era) |
Resolves: CAD-2158
JaredCorduan
force-pushed
the
jc/cad-2158
branch
from
1fa5cf0 to
92acf8f
Compare
redxaxder
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: CAD-2158