Bump to use latest released cardano-base and cardano-prelude packages #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I'm just going to double check this works, do not merge for now. |
|
thank you @michaelpj ! |
michaelpj
force-pushed
the
mpj/release-1.1-dep-bump
branch
from
812ae83 to
7ffc276
Compare
The release branch is using an unreleased commit of `cardano-base` which contains the SECP primitives but is before the `heapwords` split. This makes it incompatible with either of the released versions: - The previous version doesn't have the SECP primitives - The next version has the heapwords split In order to make the release branch usable via CHaP, I think the simplest thing is to backport the changes for the newer `cardano-base` packages, i.e. the `heapwords` split. This is a bit tedious but not too bad overall. Afterwards I'll release another version from this branch.
michaelpj
force-pushed
the
mpj/release-1.1-dep-bump
branch
from
7ffc276 to
cb29b03
Compare
|
@michaelpj why did you end up closing this PR and not pursuing it to be merged into 1.1.x? |
|
Because I was told that 1.1.x was not a real release and anyway I was trying to fix |
|
We'll use this as the basis for the 1.1.1 release, for use in IntersectMBO/cardano-node#4608. Todo:
|
1.0.0 -> 1.1.1 1.3.0 -> 1.4.1
|
Sigh, so this is green, except for a busted cicero call. |
I think we might have a few over-specified constraints here.
iohk-bors bot
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Dec 7, 2022
4608: Update ouroboros-network and cardano-ledger dependencies r=angerman a=Soupstraw This PR updates ouroboros-network and cardano-ledger dependencies. This bumps `cardano-ledger` to `0.1.1.1`, which is IntersectMBO/cardano-ledger#3080. This in turn is the `release/1.1.x` branch + heapword split compatibility introduced in `cardano-base`, which is in CHaP. It also bumps ouroboros-network to [a38f898a](https://github.com/input-output-hk/ouroboros-network/commits/a38f898a3740925ccaa0617fa870ca7054a485a6), which is 45 commits ahead of the old [c764553](https://github.com/input-output-hk/ouroboros-network/commits/c764553561bed8978d2c6753d1608dc65449617a) pin. This is one commit ahead of what IntersectMBO/ouroboros-network#3933 (on ouroboros-network/master), that made network compatible with IntersectMBO/cardano-ledger#2901 Co-authored-by: Joosep Jääger <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release branch is using an unreleased commit of
cardano-basewhich contains the SECP primitives but is before theheapwordssplit. This makes it incompatible with either of the released versions:In order to make the release branch usable via CHaP, I think the simplest thing is to backport the changes for the newer
cardano-basepackages, i.e. theheapwordssplit. This is a bit tedious but not too bad overall.Afterwards I'll release another version from this branch.