Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invalidBeforeL and invalidHereAfterL functions #3807

Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 25, 2023

Description

Lenses for ValidityInterval.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/invalidBeforeL-and-invalidHereAfterL-functions branch from ac60e7f to 288a1fd Compare October 25, 2023 11:00
@newhoggy newhoggy requested a review from lehins October 25, 2023 11:00
@newhoggy newhoggy force-pushed the newhoggy/invalidBeforeL-and-invalidHereAfterL-functions branch from 288a1fd to b4b0316 Compare October 25, 2023 11:02
@@ -118,3 +120,23 @@ evalBalanceTxBody ::
evalBalanceTxBody pp lookupKeyRefund lookupDRepRefund isRegPoolId utxo txBody =
getConsumedValue pp lookupKeyRefund lookupDRepRefund utxo txBody
<-> getProducedValue pp isRegPoolId txBody

-- | Lens to access the 'invalidBefore' field of a 'ValidityInterval' as a 'StrictMaybe SlotNo'.
invalidBeforeL :: Lens' L.ValidityInterval (StrictMaybe SlotNo)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

@newhoggy newhoggy force-pushed the newhoggy/invalidBeforeL-and-invalidHereAfterL-functions branch 2 times, most recently from 4e32ffa to 32a3569 Compare October 25, 2023 11:32
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@newhoggy newhoggy force-pushed the newhoggy/invalidBeforeL-and-invalidHereAfterL-functions branch 3 times, most recently from 1228e3c to 3678f20 Compare October 25, 2023 14:04
@lehins lehins force-pushed the newhoggy/invalidBeforeL-and-invalidHereAfterL-functions branch from 35568db to f0fda4e Compare October 25, 2023 15:03
@lehins lehins enabled auto-merge October 25, 2023 15:24
@lehins lehins merged commit f426949 into master Oct 25, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/invalidBeforeL-and-invalidHereAfterL-functions branch October 25, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants