Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GovInfoEvent's "unclaimed" field from Set to a Map #4623

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Sep 11, 2024

Description

@kderme, I this will be useful for db-sync to get access to the unclaimed amount right away, instead of forcing other to try and figure out unclaimed deposits from govActionId. Also the unclaimed amount is readily available in ledger anyways, so there is no point in discarding it.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from aniketd September 11, 2024 17:16
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I have left a suggestion for the comment on the field.

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Epoch.hs Outdated Show resolved Hide resolved
This will be useful for db-sync to get access to the unclaimed amount.
Also the unclaimed amount is readily available in ledger anyways, so
there is no point in discarding it.
@lehins lehins force-pushed the lehins/enhance-GovInfoEvent branch from 3e0d3cc to 0e9094a Compare September 12, 2024 15:29
@lehins lehins enabled auto-merge September 12, 2024 15:29
@lehins lehins merged commit db39c75 into master Sep 12, 2024
152 of 154 checks passed
@lehins lehins deleted the lehins/enhance-GovInfoEvent branch September 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants