Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the proposals workaround from UTXO conformance, add LEDGER conformance #4665

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Oct 7, 2024

Description

This PR removes a workaround in the UTXO conformance test. I modified the spec so that it doesn't add new deposits in the UTXO rule. I also moved the UTXO conformance logic into dedicated modules.

I had to disable some certificates, because the Generic generators aren't generating the deposits field correctly.

I also added conformance testing for the LEDGER rule. It seems to be succeeding in most cases, but sometimes the generators generates values that make the test fail.

closes #4672

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/utxo-proposals branch 6 times, most recently from 726b467 to 5186ddb Compare October 10, 2024 13:32
@Soupstraw Soupstraw changed the title Remove the proposals workaround from UTXO conformance Remove the proposals workaround from UTXO conformance, add LEDGER conformance Oct 10, 2024
@Soupstraw Soupstraw marked this pull request as ready for review October 10, 2024 13:56
@Soupstraw Soupstraw requested a review from a team as a code owner October 10, 2024 13:56
@Soupstraw Soupstraw force-pushed the jj/utxo-proposals branch 5 times, most recently from 5336c09 to 6e4b7e7 Compare October 11, 2024 09:24
lehins
lehins previously requested changes Oct 15, 2024
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get rid of traceShow. Other than that it looks good

eras/shelley/impl/src/Cardano/Ledger/Shelley/AdaPots.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@williamdemeo williamdemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't pretend to have carefully checked and understood everything here, but what I do understand looks good. I ran the tests (nix develop and cabal test all) and all that are implemented passed.

@Lucsanszky Lucsanszky force-pushed the jj/utxo-proposals branch 5 times, most recently from d25519a to 2083142 Compare October 16, 2024 19:03
Added LEDGER conformance test
@Lucsanszky Lucsanszky enabled auto-merge October 16, 2024 22:43
@Lucsanszky Lucsanszky dismissed lehins’s stale review October 17, 2024 00:44

Requested changes were added

@Lucsanszky Lucsanszky merged commit 4be8d27 into master Oct 17, 2024
153 of 154 checks passed
@Lucsanszky Lucsanszky deleted the jj/utxo-proposals branch October 17, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LEDGER conformance
5 participants