Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass epochNo from BBODY instead of re-computing it in downstream rules #4765

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Nov 20, 2024

Description

Closes #4692

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
instead of recomputing it from the slot
@teodanciu teodanciu force-pushed the td/pass-epochno-from-bbody branch from 6b9b872 to cc60a36 Compare November 20, 2024 19:47
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!
Thank you!

@lehins lehins enabled auto-merge November 20, 2024 21:51
@lehins lehins merged commit 0f668a3 into master Nov 20, 2024
153 of 154 checks passed
@lehins lehins deleted the td/pass-epochno-from-bbody branch November 20, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass curEpochNo instead of curSlotNo to all the rules that don't need SlotNo
2 participants