CAD-1262: Remove 'Forks created' metric. #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisshevchenko
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350 and
mrBliss
as code owners
CodiePP
approved these changes
Jun 22, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 22, 2020
1315: CAD-1262: Remove 'Forks created' metric. r=denisshevchenko a=denisshevchenko After a long discussion (initiated by #1211), it's still unclear how to measure "forks events" properly and if this metric is needed in the TUI at all. So currently we remove `forks created:` metric from the TUI. Co-authored-by: Denis Shevchenko <[email protected]>
iohk-bors bot
added a commit
to input-output-hk/cardano-benchmarking
that referenced
this pull request
Jun 22, 2020
106: CAD-1262: Remove 'Forks created' metric. r=denisshevchenko a=denisshevchenko After a long discussion (initiated by IntersectMBO/cardano-node#1211), it's still unclear how to measure "forks events" properly and if this metric is needed in the RTView at all. So currently we remove `forks created:` metric from the RTView. Corresponding changes in `cardano-node`: IntersectMBO/cardano-node#1315. Co-authored-by: Denis Shevchenko <[email protected]>
iohk-bors bot
added a commit
to input-output-hk/cardano-benchmarking
that referenced
this pull request
Jun 22, 2020
106: CAD-1262: Remove 'Forks created' metric. r=denisshevchenko a=denisshevchenko After a long discussion (initiated by IntersectMBO/cardano-node#1211), it's still unclear how to measure "forks events" properly and if this metric is needed in the RTView at all. So currently we remove `forks created:` metric from the RTView. Corresponding changes in `cardano-node`: IntersectMBO/cardano-node#1315. Co-authored-by: Denis Shevchenko <[email protected]>
iohk-bors bot
added a commit
to input-output-hk/cardano-benchmarking
that referenced
this pull request
Jun 22, 2020
106: CAD-1262: Remove 'Forks created' metric. r=CodiePP a=denisshevchenko After a long discussion (initiated by IntersectMBO/cardano-node#1211), it's still unclear how to measure "forks events" properly and if this metric is needed in the RTView at all. So currently we remove `forks created:` metric from the RTView. Corresponding changes in `cardano-node`: IntersectMBO/cardano-node#1315. Co-authored-by: Denis Shevchenko <[email protected]>
denisshevchenko
force-pushed
the
cad-1262-remove-forks-metric
branch
from
e87d75e to
09c23f0
Compare
Jimbo4350
approved these changes
Jun 30, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a long discussion (initiated by #1211), it's still unclear how to measure "forks events" properly and if this metric is needed in the TUI at all. So currently we remove
forks created:metric from the TUI.