Implement support for specifying node protocol in CLI (V2) #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
force-pushed
the
dcoutts/api-typed-tx-submit
branch
from
f2713d0 to
3158661
Compare
|
So far this only converts one command, but it should show the pattern to follow. I'll do tx submission next. This incorporates many of the changes from #1427 but based on updated APIs. |
Jimbo4350
reviewed
Jul 10, 2020
intricate
reviewed
Jul 10, 2020
intricate
force-pushed
the
dcoutts/api-typed-tx-submit
branch
2 times, most recently
from
d1b0e43 to
1c15b9e
Compare
Move it into the node where it is actually used. Add a quick hack for the chairman, to be replaced by the new proper API once that is ready.
Starting from an untyped Protocol info, make a LocalNodeConnectInfo which enforces which types can be used with which protocol modes. This will help to guide the CLI commands that interact with the node. This isn't perfect yet, but it's a lot clearer about what is necessary by tying the protocol mode to the block type, which in turn determines the types of queries, query results etc.
For the next changes, it is very helpful to have the query errors nested, since there are more of them. Co-authored-by: Luke Nadur <[email protected]>
This means that on the command line you can select if you're talking to a node that is in Byron-only mode, Shelley-mode or the composite Cardano mode. We have to handle the queries slightly differently in these cases. Co-authored-by: Luke Nadur <[email protected]>
Generalise the tx submit cli command to take a protocol mode flag that determines the mode we think the node is running in, and also generalise it to read either Byron or Shelley transactions. Then support submitting the appropriate combinations of Byron or Shelley transactions, depending on the mode.
Co-authored-by: Luke Nadur <[email protected]> Co-authored-by: Duncan Coutts <[email protected]>
intricate
force-pushed
the
dcoutts/api-typed-tx-submit
branch
from
1c15b9e to
5d455c8
Compare
intricate
approved these changes
Jul 10, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that on the command line you can select if you're talking to a node
that is in Byron-only mode, Shelley-mode or the composite Cardano mode.
We have to handle the queries slightly differently in these cases.