Allow genesis keys as tx witnesses in the API and CLI #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transactions with certs for updating the genesis delegates have to be signed by the genesis keys themselves, hence the need for witnessing transactions with genesis keys (not just genesis delegate keys).
dcoutts
requested review from
erikd,
Jimbo4350,
mrBliss and
newhoggy
as code owners
intricate
approved these changes
Jul 17, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactions with certs for updating the genesis delegates have to be
signed by the genesis keys themselves, hence the need for witnessing
transactions with genesis keys (not just genesis delegate keys).