Trace hard fork transition events #1520

mrBliss · 2020-07-22T08:31:36Z

This will trace events like:

HardForkUpdateTransitionConfirmed
HardForkUpdateTransitionDone
HardForkUpdateTransitionRolledBack
...

cabal.project

mrBliss · 2020-07-22T17:15:20Z

This is what the structured output looks like on mainnet_candidate:

{"at":"2020-07-22T17:13:12.99Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"5e8ac3@194","events":[{"protocolUpdates":[{"protocolUpdateVersion":{"pvMajor":1,"pvMinor":0,"pvAlt":0},"protocolUpdateState":{"kind":"UpdateRegistered","slot":194}}],"kind":"ByronUpdatedProtocolUpdates"}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}
{"at":"2020-07-22T17:13:12.99Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"ddcf74@195","events":[{"protocolUpdates":[{"protocolUpdateVersion":{"pvMajor":1,"pvMinor":0,"pvAlt":0},"protocolUpdateState":{"kind":"UpdateConfirmed","slot":195}}],"kind":"ByronUpdatedProtocolUpdates"}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}
{"at":"2020-07-22T17:13:13.27Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"79c8b0@411","events":[{"protocolUpdates":[{"protocolUpdateVersion":{"pvMajor":1,"pvMinor":0,"pvAlt":0},"protocolUpdateState":{"kind":"UpdateCandidate","slot":411}}],"kind":"ByronUpdatedProtocolUpdates"}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}
{"at":"2020-07-22T17:13:13.65Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"d04085@627","events":[{"protocolUpdates":[{"protocolUpdateVersion":{"pvMajor":1,"pvMinor":0,"pvAlt":0},"protocolUpdateState":{"kind":"UpdateStableCandidate","transitionEpoch":1}}],"kind":"ByronUpdatedProtocolUpdates"}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}
{"at":"2020-07-22T17:13:14.57Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"375e8c@1080","events":[{"protocolUpdates":[],"kind":"ByronUpdatedProtocolUpdates"}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}

{"at":"2020-07-22T17:14:06.35Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"8ff654@17466","events":[{"protocolUpdates":[{"protocolUpdateVersion":{"pvMajor":2,"pvMinor":0,"pvAlt":0},"protocolUpdateState":{"kind":"UpdateRegistered","slot":17466}}],"kind":"ByronUpdatedProtocolUpdates"}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}
{"at":"2020-07-22T17:14:06.36Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"ea9ea5@17467","events":[{"protocolUpdates":[{"protocolUpdateVersion":{"pvMajor":2,"pvMinor":0,"pvAlt":0},"protocolUpdateState":{"kind":"UpdateConfirmed","slot":17467}}],"kind":"ByronUpdatedProtocolUpdates"}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}
{"at":"2020-07-22T17:14:09.97Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"34061f@17683","events":[{"protocolUpdates":[{"protocolUpdateVersion":{"pvMajor":2,"pvMinor":0,"pvAlt":0},"protocolUpdateState":{"kind":"UpdateCandidate","slot":17683}}],"kind":"ByronUpdatedProtocolUpdates"}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}
{"at":"2020-07-22T17:14:12.74Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"a53783@17899","events":[{"protocolUpdates":[{"protocolUpdateVersion":{"pvMajor":2,"pvMinor":0,"pvAlt":0},"protocolUpdateState":{"kind":"UpdateStableCandidate","transitionEpoch":17}}],"kind":"ByronUpdatedProtocolUpdates"},{"kind":"HardForkUpdateTransitionConfirmed","toEra":"Shelley","fromEra":"Byron","transitionEpoch":17}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}

{"at":"2020-07-22T17:14:29.25Z","env":"1.16.0:ab846","ns":["cardano.node.ChainDB"],"data":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"\"fe59c3@19860","events":[{"kind":"HardForkUpdateTransitionDone","toEra":"Shelley","fromEra":"Byron","transitionEpoch":17}]},"app":[],"msg":"","pid":"1295156","loc":null,"host":"desktop","sev":"Notice","thread":"33"}

intricate · 2020-07-22T17:22:56Z

cardano-config/src/Cardano/TracingOrphanInstances/Byron.hs

+instance ToObject ProtocolUpdate where
+  toObject verb (ProtocolUpdate updateVersion updateState) =
+    mkObject $
+      [ "protocolUpdateVersion" .= updateVersion
+      , "protocolUpdateState"   .= toObject verb updateState
+      ]


Are we purposefully not providing a kind field here?

Probably not. I suggest add it.

Oh, not purposefully, will fix it. BTW, if a kind field is mandatory, maybe mkObject should take it as an argument?

intricate · 2020-07-22T17:24:54Z

cardano-config/src/Cardano/TracingOrphanInstances/Consensus.hs

        <> showT (unSlotNo slotNo)
        <> ", but we cannot lead because: "
        <> showT reason
    TraceNoLedgerState slotNo _blk -> const $
-      "No ledger state at slot " <> showT (unSlotNo slotNo)
+      "No ledger state for slot " <> showT (unSlotNo slotNo)


I don't think it really matters much, but should we stay consistent with your changes and say "in slot"?

Suggested change

"No ledger state for slot " <> showT (unSlotNo slotNo)

"No ledger state in slot " <> showT (unSlotNo slotNo)

This made me realise that it's still not right, I now changed it to:

TraceNoLedgerState slotNo pt -> const $ "Could not obtain ledger state for point " <> pack (showPoint MaximalVerbosity immutableTipPoint) <> ", current slot: " <> showT (unSlotNo slotNo)

Because we're asking a ledger state for a point, not the current slot.

I also intentionally use "for slot" for TraceNoLedgerView, because we're asking for a forecast of the LedgerView for a particular slot using forecastFor.

dcoutts

LGTM, modulo the couple copy'n'paste fixes below.

cardano-config/src/Cardano/TracingOrphanInstances/HardFork.hs

mrBliss · 2020-07-22T18:34:33Z

bors merge

1520: Trace hard fork transition events r=mrBliss a=mrBliss This will trace events like: * `HardForkUpdateTransitionConfirmed` * `HardForkUpdateTransitionDone` * `HardForkUpdateTransitionRolledBack` * ... Co-authored-by: Thomas Winant <[email protected]>

dcoutts · 2020-07-22T18:55:44Z

cardano-config/src/Cardano/TracingOrphanInstances/Consensus.hs

+    TraceNoLedgerState slotNo pt -> const $
+      "Could not obtain ledger state for point "
+        <> pack (showPoint MaximalVerbosity immutableTipPoint)


immutableTipPoint is apparently not in scope.

Right after fixing a few copy'n'pastos, I make another one 🤦. I would blame ghcide for being unreliable in showing type errors (all green), but I should have run cabal build all to check.

iohk-bors · 2020-07-22T19:04:20Z

Build failed

ci/hydra-build:required

For example `TraceBlockFromFuture`, was incorrect.

mrBliss · 2020-07-22T20:12:26Z

bors merge

1520: Trace hard fork transition events r=mrBliss a=mrBliss This will trace events like: * `HardForkUpdateTransitionConfirmed` * `HardForkUpdateTransitionDone` * `HardForkUpdateTransitionRolledBack` * ... Co-authored-by: Thomas Winant <[email protected]>

mrBliss · 2020-07-22T20:49:28Z

Bors crashed, this PR is cursed.

mrBliss · 2020-07-22T20:50:11Z

bors merge

iohk-bors · 2020-07-22T21:03:19Z

Build succeeded

mrBliss commented Jul 22, 2020

View reviewed changes

cabal.project Outdated Show resolved Hide resolved

mrBliss force-pushed the mrBliss/trace-transition-events branch 2 times, most recently from 1c2ddee to f8500e9 Compare July 22, 2020 13:39

mrBliss force-pushed the mrBliss/trace-transition-events branch from f8500e9 to 8e46b94 Compare July 22, 2020 17:15

mrBliss marked this pull request as ready for review July 22, 2020 17:15

mrBliss requested review from dcoutts, erikd, intricate, Jimbo4350 and newhoggy as code owners July 22, 2020 17:15

mrBliss requested a review from disassembler July 22, 2020 17:15

intricate approved these changes Jul 22, 2020

View reviewed changes

dcoutts approved these changes Jul 22, 2020

View reviewed changes

cardano-config/src/Cardano/TracingOrphanInstances/HardFork.hs Outdated Show resolved Hide resolved

cardano-config/src/Cardano/TracingOrphanInstances/HardFork.hs Outdated Show resolved Hide resolved

mrBliss added 3 commits July 22, 2020 20:23

Trace hard fork transition events

eb98549

Let the severity depend on the LedgerEvent

f09f35e

Never elide a trace message containing a LedgerEvent

12c4e65

mrBliss force-pushed the mrBliss/trace-transition-events branch from 8e46b94 to 290de71 Compare July 22, 2020 18:33

dcoutts reviewed Jul 22, 2020

View reviewed changes

Fix some incorrect descriptions of TraceForgeEvent

35309ff

For example `TraceBlockFromFuture`, was incorrect.

mrBliss force-pushed the mrBliss/trace-transition-events branch from 290de71 to 35309ff Compare July 22, 2020 20:11

iohk-bors bot merged commit 95d4122 into master Jul 22, 2020

iohk-bors bot deleted the mrBliss/trace-transition-events branch July 22, 2020 21:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trace hard fork transition events #1520

Trace hard fork transition events #1520

mrBliss commented Jul 22, 2020

mrBliss commented Jul 22, 2020

intricate Jul 22, 2020

dcoutts Jul 22, 2020

mrBliss Jul 22, 2020

intricate Jul 22, 2020

mrBliss Jul 22, 2020

dcoutts left a comment

mrBliss commented Jul 22, 2020

dcoutts Jul 22, 2020

mrBliss Jul 22, 2020

iohk-bors bot commented Jul 22, 2020

mrBliss commented Jul 22, 2020

mrBliss commented Jul 22, 2020 •

edited

Loading

mrBliss commented Jul 22, 2020

iohk-bors bot commented Jul 22, 2020

	"No ledger state for slot " <> showT (unSlotNo slotNo)
	"No ledger state in slot " <> showT (unSlotNo slotNo)

Trace hard fork transition events #1520

Trace hard fork transition events #1520

Conversation

mrBliss commented Jul 22, 2020

mrBliss commented Jul 22, 2020

intricate Jul 22, 2020

Choose a reason for hiding this comment

dcoutts Jul 22, 2020

Choose a reason for hiding this comment

mrBliss Jul 22, 2020

Choose a reason for hiding this comment

intricate Jul 22, 2020

Choose a reason for hiding this comment

mrBliss Jul 22, 2020

Choose a reason for hiding this comment

dcoutts left a comment

Choose a reason for hiding this comment

mrBliss commented Jul 22, 2020

dcoutts Jul 22, 2020

Choose a reason for hiding this comment

mrBliss Jul 22, 2020

Choose a reason for hiding this comment

iohk-bors bot commented Jul 22, 2020

Build failed

mrBliss commented Jul 22, 2020

mrBliss commented Jul 22, 2020 • edited Loading

mrBliss commented Jul 22, 2020

iohk-bors bot commented Jul 22, 2020

Build succeeded

mrBliss commented Jul 22, 2020 •

edited

Loading