Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to launch non-Byron-only testnet with custom activeSlotCoeff #2122

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Nov 25, 2020

No description provided.

@newhoggy newhoggy force-pushed the testnet-with-custom-activeSlotsCoeff branch 2 times, most recently from 093d112 to 9de7ada Compare November 25, 2020 05:14
@newhoggy newhoggy force-pushed the testnet-with-custom-activeSlotsCoeff branch from 9de7ada to eef69d6 Compare November 25, 2020 05:16
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, but the message in the PR:

$ for x in {1..1}; do (export KEEP_WORKSPACE=1; cd carda .......

is probably not something we want in git history forever.

@newhoggy
Copy link
Contributor Author

Change the text to use a slightly better command. Note this just in the PR description and not in the git history.

@erikd
Copy link
Contributor

erikd commented Nov 25, 2020

Yes, but if you use github to merge it, it will be in the git history.

@newhoggy
Copy link
Contributor Author

That's awkward. Moved it into a comment:

The following shows that the genesis files get updated to have the provided activeSlotCoeff value:

$ (cd cardano-node-chairman; export KEEP_WORKSPACE=1; cabal run -- cardano-testnet shelley --active-slots-coeff 0.25)
$ for x in $(find /private/var/folders/zh/ln41q4zs52x2fd61rxccmq640000gn/T/chairman/test-2dbb537814cf6ce0/ -name 'g*.json'); do echo "== $x =="; cat $x | jq . | grep eff; done
== /private/var/folders/zh/ln41q4zs52x2fd61rxccmq640000gn/T/chairman/test-2dbb537814cf6ce0//genesis.json ==
  "activeSlotsCoeff": 0.25,
== /private/var/folders/zh/ln41q4zs52x2fd61rxccmq640000gn/T/chairman/test-2dbb537814cf6ce0//genesis.spec.json ==
  "activeSlotsCoeff": 0.25,

@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 25, 2020

@iohk-bors iohk-bors bot merged commit 0738ec0 into master Nov 25, 2020
@iohk-bors iohk-bors bot deleted the testnet-with-custom-activeSlotsCoeff branch November 25, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants