Update query cli commands to handle Allegra and Mary eras #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
reviewed
Nov 29, 2020
Jimbo4350
force-pushed
the
jordan/update-cli-queries-mary-allegra
branch
3 times, most recently
from
c07b79a to
8b7cb71
Compare
dcoutts
force-pushed
the
jordan/update-cli-queries-mary-allegra
branch
from
8b7cb71 to
74877cb
Compare
First step of updating all the query commands to support the Allegra and Mary eras. In principle the queries could find out the era from the node itself, but this is a bit awkward so for now we require an extra cli flag.
Fail if this is not the case.
We pass the era in where needed. Generalise various helper functions over era type classes. For now the UTxO printing code relies on the value type being coin specifically, which means we do not yet support the Mary era. Add a couple functions for obtaining required era class constraints or type equality constraints based on the era: * obtainLedgerEraClassConstraints * requireValueTypeIsCoin The latter is used for the UTxO printing part to satisfy their constraints.
They all follow more or less the same pattern. Various helper functions become polymorphic with class and type equality constraints. We then need a couple more helper functions for obtaining the necessary constraints so they're available where we need them.
dcoutts
force-pushed
the
jordan/update-cli-queries-mary-allegra
branch
from
74877cb to
99ac681
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.