-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAD-2378 CAD-2377 Node logging fixes #2192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepfire
force-pushed
the
cad-2378-cad-2377-tx-processed-count-metric
branch
3 times, most recently
from
December 7, 2020 15:07
183f35e
to
fb15fe6
Compare
deepfire
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350,
mrBliss and
newhoggy
as code owners
December 7, 2020 15:15
Windows Github Actions failures are due to failure to install |
deepfire
force-pushed
the
cad-2378-cad-2377-tx-processed-count-metric
branch
from
December 7, 2020 15:35
fb15fe6
to
c1549c2
Compare
dcoutts
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
bors r+ |
intricate
approved these changes
Dec 7, 2020
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapForgingStatsTxsProcessed
instead of previous state (https://github.com/input-output-hk/cardano-node/blob/master/cardano-node/src/Cardano/Tracing/Metrics.hs#L143-L145)ChainDB
andForge
metrics at old namespace locations