-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable idle GC in the default nix build #3349
Conversation
@jbgi Not sure who to tag, but I've seen you've worked on this file. :) |
I think this rts option is already set at compile time: |
Hmm. I thought it was maybe overriding the default, but apparently not. I was trying to debug running the Daedalus / cardano-node combination but no luck so far with the nix build. But it seems cardano-node is always using 100% of one core when running from Daedalus. I'll try to investigate further. |
One more question. I'm not very familiar with nixos or native binaries and their linking to libraries and stuff. But do you think that running a https://github.com/input-output-hk/daedalus/blob/develop/nix/cardano-bridge.nix#L24 Such as done here. |
I'm getting closer, it's not here. :P |
@jbgi It seems the NixOS parameters are used when running from NixOS. I think -I0 would be a good addition still. |
bors r+ |
bors retry |
@jbgi Do I have to make any changes to fix the build? |
bors r+ |
Build succeeded: |
I guess this is what's causing cardano-node constantly high CPU usage when running in Daedalus.
My suggestion would be to also add "-c" - always compact oldest generation instead of copying collection. Since most heap data is very long-lived, this can cause considerably less memory usage.