Guard against overflows in Shelley TxIns #3478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevanspowell
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
Jimbo4350,
nc6 and
newhoggy
as code owners
6 tasks
sevanspowell
force-pushed
the
sevanspowell/txin-overflow
branch
from
d29e17e to
830ef2d
Compare
|
@sevanspowell can you rebase this on |
newhoggy
requested review from
LudvikGalois and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
sevanspowell/txin-overflow
branch
7 times, most recently
from
5d5a73b to
c96c023
Compare
newhoggy
requested review from
deepfire,
jutaro,
mgmeier,
fmaste and
cleverca22
as code owners
newhoggy
force-pushed
the
sevanspowell/txin-overflow
branch
2 times, most recently
from
1906e9e to
bb32fec
Compare
newhoggy
force-pushed
the
sevanspowell/txin-overflow
branch
from
bb32fec to
5068c49
Compare
|
To be merged in #4956 to trigger CI |
- makeByronTransactionBody guards against overflows in the transaction indices, but makeShelleyTransactionBody does not. - Add appropriate guards to makeShelleyTransactionBody.
newhoggy
force-pushed
the
sevanspowell/txin-overflow
branch
from
5068c49 to
dcc5597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but makeShelleyTransactionBody does not.
Now, I have no idea if the
maxShelleyTxInIxvalue here is correct, so help would be appreciated!