Reduce flakiness of tests #3596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
commented
Feb 13, 2022
| @@ -189,7 +190,7 @@ jobs: | |||
| if: ${{ always() }} | |||
| continue-on-error: true | |||
| with: | |||
| name: chairman-test-artifacts-${{ matrix.os }}-${{ matrix.ghc }} | |||
| name: chairman-test-artifacts-${{ matrix.os }}-${{ matrix.n }}-${{ matrix.ghc }} | |||
There was a problem hiding this comment.
This is needed so that when there is more than one n, the logs don't clobber each other.
newhoggy
force-pushed
the
newhoggy/less-flaky-tests
branch
5 times, most recently
from
282e602 to
68e2d98
Compare
* Retry testnet tests when they fail * Retry parts of complex tests when they fail * Reduce number of BFT nodes * Set BFT nodes to 1 * Update cardano-crypto dependency
newhoggy
force-pushed
the
newhoggy/less-flaky-tests
branch
from
86100a0 to
4f2f1a5
Compare
newhoggy
requested review from
DavidEichmann,
dcoutts,
Jimbo4350,
erikd,
nc6 and
JaredCorduan
as code owners
newhoggy
changed the title
Jimbo4350
reviewed
Feb 18, 2022
| @@ -25,6 +25,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| n: [1] # Add more elements here to run additional copies of tests | |||
| if currEpoch == desiredEpoch | ||
| Just currEpoch -> do | ||
|
|
||
| if currEpoch >= desiredEpoch |
| import GHC.Stack (callStack) | ||
| import qualified System.Directory as IO | ||
| import Hedgehog (Property, (/==), (===)) |
There was a problem hiding this comment.
Why all the module import rearrangement?
| @@ -571,7 +558,7 @@ hprop_plutus_certifying_withdrawing = H.integration . H.runFinallies . H.workspa | |||
|
|
|||
| utxoPlutus /== mempty | |||
|
|
|||
| H.note_ "Wait for rewards to be paid out. This will be current epoch + 4" | |||
| H.note_ "Wait for rewards to be paid out. This will be current epoch + 5" | |||
There was a problem hiding this comment.
Where did you read it was + 5?
| H.note_ "Check we have reached 4 epochs ahead" | ||
| waitedEpoch === rewardsEpoch | ||
|
|
||
| H.note_ "Check we have reached 5 epochs ahead" |
| @@ -611,7 +611,7 @@ hprop_plutus_certifying_withdrawing = H.integration . H.runFinallies . H.workspa | |||
|
|
|||
| let minrequtxo = 999978 | |||
|
|
|||
| pr <- H.byDurationM 3 60 $ do | |||
| pr <- H.noteShowM . H.byDurationM 3 60 $ do | |||
There was a problem hiding this comment.
We can squash this commit
Merged
|
This PR is replaced by #4575 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.