Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ToJSON and FromJSON instances for Address #4568

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Add ToJSON and FromJSON instances for Address #4568

merged 1 commit into from
Oct 28, 2022

Conversation

MarcFontaine
Copy link
Contributor

No description provided.

@MarcFontaine MarcFontaine mentioned this pull request Oct 27, 2022
Closed
@MarcFontaine
Copy link
Contributor Author

These are the reusable bits from #1888.
The other parts of the functionality from #1888 have landed in master already.

Jimbo4350
Jimbo4350 approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor change

cardano-api/src/Cardano/Api/Address.hs Outdated Show resolved Hide resolved
@MarcFontaine MarcFontaine force-pushed the mafo/address-JSON-instances branch 2 times, most recently from f6ccc54 to 22f872c Compare October 27, 2022 14:26
@MarcFontaine
Copy link
Contributor Author

bors r+

@MarcFontaine MarcFontaine self-assigned this Oct 27, 2022
@MarcFontaine MarcFontaine added the enhancement New feature or request label Oct 27, 2022
iohk-bors bot added a commit that referenced this pull request Oct 27, 2022
@iohk-bors @NeilBurgess42 @MarcFontaine
Merge #3701 #4568
5476868 
3701: CAD-3928 minor polish r=Jimbo4350 a=NeilBurgess42

Minor changes to conform with IOG style guide.

4568: Add ToJSON and FromJSON instances for Address r=MarcFontaine a=MarcFontaine



Co-authored-by: neilburgess42 <[email protected]>
Co-authored-by: MarcFontaine <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 27, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from input-output-hk/docs-access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@MarcFontaine MarcFontaine force-pushed the mafo/address-JSON-instances branch from 22f872c to 7723cf2 Compare October 28, 2022 08:03
@MarcFontaine
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 28, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 51befb0 into master Oct 28, 2022
@iohk-bors iohk-bors bot deleted the mafo/address-JSON-instances branch October 28, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees

@MarcFontaine MarcFontaine

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcFontaine @Jimbo4350