Move implementation inside runTransactionCmd to toplevel definitions.
#4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcFontaine
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
Jimbo4350
requested changes
Nov 28, 2022
| @@ -447,6 +302,215 @@ runTransactionCmd cmd = | |||
| -- Building transactions | |||
| -- | |||
|
|
|||
| runTxBuildCmd | |||
| :: IsCardanoEra era | |||
| => CardanoEra era | |||
There was a problem hiding this comment.
LGTM, however lets use AnyCardanoEra here and add some haddock annotations to the parameters where it's not obvious what they are e.g Maybe Word. The haddocks don't have to be overly descriptive, short succinct ones will do.
MarcFontaine
force-pushed
the
mafo/4672-cleanup-case
branch
from
f0aa006 to
8ec395f
Compare
MarcFontaine
force-pushed
the
mafo/4672-cleanup-case
branch
from
8ec395f to
29edb03
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.