Update ouroboros-network #4764
Closed
Update ouroboros-network #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/update-ouroboros-network
branch
from
ec17c33 to
c0f0068
Compare
This was referenced Jan 10, 2023
newhoggy
force-pushed
the
newhoggy/update-ouroboros-network
branch
2 times, most recently
from
b49d48b to
cf8893f
Compare
coot
reviewed
Jan 11, 2023
| @@ -133,6 +133,8 @@ library | |||
| , ouroboros-consensus-protocol | |||
| , ouroboros-consensus-shelley | |||
| , ouroboros-network | |||
| , ouroboros-network-api | |||
| , ouroboros-network-protocols | |||
There was a problem hiding this comment.
Nice, so cardano-cli does not depend on ouroboros-consensus-diffusion :)
| @@ -168,10 +168,13 @@ library | |||
| , ouroboros-consensus ^>= 0.1.0.2 | |||
| , ouroboros-consensus-byron | |||
| , ouroboros-consensus-cardano | |||
| , ouroboros-consensus-diffusion | |||
| @@ -140,7 +140,7 @@ library | |||
| , filepath | |||
| , mime-mail | |||
| , optparse-applicative | |||
| , ouroboros-network | |||
| , ouroboros-network-api | |||
newhoggy
force-pushed
the
newhoggy/update-ouroboros-network
branch
from
cf8893f to
af8f0d6
Compare
newhoggy
force-pushed
the
newhoggy/update-ouroboros-network
branch
from
af8f0d6 to
6f97301
Compare
newhoggy
requested review from
Jimbo4350,
a team,
deepfire,
jutaro,
mgmeier,
fmaste,
cleverca22,
dcoutts,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
newhoggy/update-ouroboros-network
branch
from
6f97301 to
a7ac826
Compare
newhoggy
force-pushed
the
newhoggy/update-ouroboros-network
branch
from
a7ac826 to
c7159a2
Compare
|
bump 😄 |
coot
requested changes
Mar 8, 2023
Comment on lines
+172
to
+176
| source-repository-package | ||
| type: git | ||
| location: https://github.com/input-output-hk/ekg-forward-fork | ||
| tag: 6cf25fbbaf9815e07f695982da4cfbb1581239c3 | ||
| --sha256: 0qwvx04l9q3h7acb0a3b8iarqcn5bkqhwaplbga5pvryqp3lhn00 |
There was a problem hiding this comment.
Why are we using a fork of our own library?
There was a problem hiding this comment.
Also we shouldn't use srps any more, if we need a newer version of ekg-forward lets release one to CHaP.
|
This is obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block by IntersectMBO/ouroboros-network#4261, because
ouroboros-networkis unusable due to malformed cabal files.