Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reconfigure-hlint.sh script #4838

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jan 24, 2023

  • Remove the reconfigure-hlint.sh work around which is no longer needed.
  • Add Github Actions workflow for hlint
  • Unfortunately I have stylish-haskell formatting, so there are import format changes too.

@newhoggy newhoggy marked this pull request as ready for review January 24, 2023 18:24
@newhoggy newhoggy force-pushed the newhoggy/remove-reconfigure-hlint-script branch 7 times, most recently from 62d6226 to d5d624e Compare January 24, 2023 19:58
@newhoggy newhoggy force-pushed the newhoggy/remove-reconfigure-hlint-script branch 3 times, most recently from f2d99d1 to 969c17f Compare January 24, 2023 21:04
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newhoggy, I have to ask to remove all formatting changes in the bench/ folder -- including removal of ImportQualifiedPost.

@newhoggy newhoggy force-pushed the newhoggy/remove-reconfigure-hlint-script branch 2 times, most recently from ca07877 to 90619e1 Compare January 25, 2023 07:36
@newhoggy newhoggy dismissed deepfire’s stale review January 25, 2023 07:37

Comments addressed.

@newhoggy newhoggy requested a review from deepfire January 25, 2023 07:37
@newhoggy
Copy link
Contributor Author

I have to ask to remove all formatting changes in the bench/ folder -- including removal of ImportQualifiedPost.

This is removed now.

@jbgi jbgi force-pushed the newhoggy/remove-reconfigure-hlint-script branch from 90619e1 to a681e64 Compare January 26, 2023 13:47
@jbgi
Copy link
Contributor

jbgi commented Jan 26, 2023

bors merge

iohk-bors bot added a commit that referenced this pull request Jan 26, 2023
4838: Remove reconfigure-hlint.sh script r=jbgi a=newhoggy

* Remove the `reconfigure-hlint.sh` work around which is no longer needed.
* Add Github Actions workflow for `hlint`
* Unfortunately I have `stylish-haskell` formatting, so there are import format changes too.

Co-authored-by: John Ky <[email protected]>
@jbgi
Copy link
Contributor

jbgi commented Jan 26, 2023

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 26, 2023

Canceled.

@jbgi
Copy link
Contributor

jbgi commented Jan 26, 2023

bors merge

iohk-bors bot added a commit that referenced this pull request Jan 26, 2023
4772: workbench: publish analysis r=fmaste a=fmaste

Integrates `bench-data-publish` into the workbench, either to publish analyses to a local Postgres server or to the cloud Postgres server. To use the latter, it provides subcommands to create a tunnel and authenticate with it (see `wb publish ?` inside the shell) 

4838: Remove reconfigure-hlint.sh script r=jbgi a=newhoggy

* Remove the `reconfigure-hlint.sh` work around which is no longer needed.
* Add Github Actions workflow for `hlint`
* Unfortunately I have `stylish-haskell` formatting, so there are import format changes too.

4850: update tullia to get fix in cue lib r=dermetfan a=dermetfan



Co-authored-by: Federico Mastellone <[email protected]>
Co-authored-by: John Ky <[email protected]>
Co-authored-by: Jean-Baptiste Giraudeau <[email protected]>
Co-authored-by: Robin Stumm <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 26, 2023

Build failed (retrying...):

iohk-bors bot added a commit that referenced this pull request Jan 26, 2023
4838: Remove reconfigure-hlint.sh script r=jbgi a=newhoggy

* Remove the `reconfigure-hlint.sh` work around which is no longer needed.
* Add Github Actions workflow for `hlint`
* Unfortunately I have `stylish-haskell` formatting, so there are import format changes too.

4850: update tullia to get fix in cue lib r=dermetfan a=dermetfan



Co-authored-by: John Ky <[email protected]>
Co-authored-by: Jean-Baptiste Giraudeau <[email protected]>
Co-authored-by: Robin Stumm <[email protected]>
@jbgi
Copy link
Contributor

jbgi commented Jan 26, 2023

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 26, 2023

Canceled.

@jbgi
Copy link
Contributor

jbgi commented Jan 26, 2023

bors merge

iohk-bors bot added a commit that referenced this pull request Jan 26, 2023
4838: Remove reconfigure-hlint.sh script r=jbgi a=newhoggy

* Remove the `reconfigure-hlint.sh` work around which is no longer needed.
* Add Github Actions workflow for `hlint`
* Unfortunately I have `stylish-haskell` formatting, so there are import format changes too.

4850: update tullia to get fix in cue lib r=dermetfan a=dermetfan



Co-authored-by: John Ky <[email protected]>
Co-authored-by: Jean-Baptiste Giraudeau <[email protected]>
Co-authored-by: Robin Stumm <[email protected]>
@jbgi
Copy link
Contributor

jbgi commented Jan 26, 2023

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 26, 2023

Canceled.

@jbgi
Copy link
Contributor

jbgi commented Jan 26, 2023

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 26, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 9ab4b98 into master Jan 26, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/remove-reconfigure-hlint-script branch January 26, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants