-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to write keys in bech32 #5058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/option-to-write-keys-in-bech32
branch
5 times, most recently
from
April 5, 2023 12:28
89f96b3
to
dc7ef0d
Compare
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
April 5, 2023 12:28
newhoggy
force-pushed
the
newhoggy/option-to-write-keys-in-bech32
branch
6 times, most recently
from
April 13, 2023 03:37
e218bc4
to
8059696
Compare
carbolymer
approved these changes
Apr 13, 2023
newhoggy
force-pushed
the
newhoggy/option-to-write-keys-in-bech32
branch
7 times, most recently
from
April 19, 2023 09:30
d6d3eea
to
192e4e1
Compare
newhoggy
force-pushed
the
newhoggy/option-to-write-keys-in-bech32
branch
2 times, most recently
from
April 27, 2023 01:24
e4dee3d
to
26f9ebc
Compare
newhoggy
force-pushed
the
newhoggy/option-to-write-keys-in-bech32
branch
from
May 8, 2023 02:55
26f9ebc
to
e76b16e
Compare
disassembler
approved these changes
May 8, 2023
newhoggy
force-pushed
the
newhoggy/option-to-write-keys-in-bech32
branch
2 times, most recently
from
May 11, 2023 14:40
ee6e722
to
34e4efb
Compare
…', 'node key-gen-VRF', 'genesis create-staked' and 'genesis create' commands.
newhoggy
force-pushed
the
newhoggy/option-to-write-keys-in-bech32
branch
from
June 1, 2023 04:15
34e4efb
to
65e7a4a
Compare
@newhoggy @disassembler the default for the --key-output-format is currently "text-envelope" (json), but the parameter help output for cardano-cli states that "bech32" is the default mode:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to output keys in
bech32
format.The functionality was extracted from #1979 and refactored to make #5016 easier to implement.
The functionality was extracted because there was concern about backwards compatibility in that PR. This PR implements the change in a backwards compatible way by introducing a new optional flag.
This PR is limited to the writing of bech32. The reading of bech32 is to be implemented separately to avoid making this PR to large.
Changes:
--out-file
argument to theshelley stake-pool id
command.--key-format-output
argument to the following commands:address key-gen
stake-address key-gen
node key-gen
node key-gen-KES
node key-gen-VRF
genesis create-staked
genesis create
Depends on #5049, #5057 and #5059. Please review those first.
Before those are merged, it is recommended to review this PR commit-by-commit starting from the commit with the message "Rename OutputFormat to PoolIdOutputFormat for clarity"