Initial ledger events integration into cardano-testnet #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/initial-ledger-events-integration
branch
3 times, most recently
from
595b9fd to
3669601
Compare
Jimbo4350
force-pushed
the
jordan/initial-ledger-events-integration
branch
2 times, most recently
from
290d258 to
96051c8
Compare
carbolymer
reviewed
Nov 2, 2023
| then return (currentEvents ++ acc, StopFold) | ||
| else return (currentEvents ++ acc, ContinueFold) | ||
| where | ||
| -- We end the fold on PoolReap ledger event |
There was a problem hiding this comment.
that's not 100% true, because foldBlocks will continue iterating over knownLedgerStates' even when we return StopFold
There was a problem hiding this comment.
Jimbo4350
force-pushed
the
jordan/initial-ledger-events-integration
branch
from
96051c8 to
1209e31
Compare
53 tasks
Jimbo4350
force-pushed
the
jordan/initial-ledger-events-integration
branch
7 times, most recently
from
5e5ddf9 to
e8540c5
Compare
This is a simple demonstration as to how we can use `foldBlocks` with `cardano-testnet` for testing purposes
Jimbo4350
force-pushed
the
jordan/initial-ledger-events-integration
branch
from
e8540c5 to
48c35be
Compare
newhoggy
reviewed
Nov 27, 2023
| <- cardanoTestnet fastTestnetOptions conf | ||
| NodeRuntime{nodeSprocket} <- H.headM $ poolRuntime <$> poolNodes testnetRuntime | ||
| let socketName' = IO.sprocketName nodeSprocket | ||
| socketBase = IO.sprocketBase nodeSprocket -- /tmp |
There was a problem hiding this comment.
Do you still need the /tmp comment?
There was a problem hiding this comment.
I do to remind myself that the base is tmp
newhoggy
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We introduce a sanity check test in cardano-testnet for
foldBlocks. It also serves as a simple example as to how it should be integrated with property tests.Depends on: IntersectMBO/cardano-api#350
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.