Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-testnet | Add cardano-cli query treasury check in treasury growth test #5919

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 24, 2024

Description

Add cardano-cli query treasury check to treasury growth test.
Tests IntersectMBO/cardano-cli#845

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer changed the title Mgalazyn/test/query treasury cardano-testnet | Add cardano-cli query treasury test Jul 24, 2024
@carbolymer carbolymer force-pushed the mgalazyn/test/query-treasury branch 3 times, most recently from facfbda to 52b076a Compare July 25, 2024 08:25
@carbolymer carbolymer force-pushed the mgalazyn/test/query-treasury branch from 52b076a to afa50eb Compare July 25, 2024 08:42
@carbolymer carbolymer changed the title cardano-testnet | Add cardano-cli query treasury test cardano-testnet | Add cardano-cli query treasury check in treasury growth test Jul 25, 2024
@carbolymer carbolymer marked this pull request as ready for review July 25, 2024 08:44
@carbolymer carbolymer requested a review from a team as a code owner July 25, 2024 08:44
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@carbolymer carbolymer enabled auto-merge July 29, 2024 17:59
@carbolymer carbolymer added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@carbolymer carbolymer merged commit f215bf6 into master Jul 30, 2024
24 of 26 checks passed
@carbolymer carbolymer deleted the mgalazyn/test/query-treasury branch July 30, 2024 13:04
@carbolymer
Copy link
Contributor Author

Force merging because hydra was failing due to testnet flakiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants