cardano-testnet: test value delegated to dreps in test of drep-stake-distribution #5961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
force-pushed
the
smelc/check-query-drep-stake-distribution-value
branch
from
9547c48 to
b88b24c
Compare
carbolymer
reviewed
Aug 30, 2024
| -- TODO: we could check that the Coin amount below is the one reported | ||
| -- by query stake-address-info | ||
|
|
||
| forM_ drepStakeDistribution $ \(_drep, coin) -> coin H.=== Coin 300_000_000_000 |
There was a problem hiding this comment.
Why no list lenght check?
Also small nitpick, because how hedgehog renders failure, it's a little more readable to put expected value on the left hand side.
Suggested change
| forM_ drepStakeDistribution $ \(_drep, coin) -> coin H.=== Coin 300_000_000_000 | |
| forM_ drepStakeDistribution $ \(_drep, coin) -> Coin 300_000_000_000 H.=== coin |
There was a problem hiding this comment.
@carbolymer> I added a list check and swapped the operands of H.=== 👍
carbolymer
approved these changes
Aug 30, 2024
smelc
force-pushed
the
smelc/check-query-drep-stake-distribution-value
branch
from
b88b24c to
21bc46f
Compare
3 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
smelc
force-pushed
the
smelc/check-query-drep-stake-distribution-value
branch
from
21bc46f to
4deed3c
Compare
smelc
force-pushed
the
smelc/check-query-drep-stake-distribution-value
branch
from
4deed3c to
de5e092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IntersectMBO/cardano-cli#874 is changing the way the maximum supply in
create-testnet-datais handled. As a consequence this affectscardano-testnet. This is why we want to check that the changes in values when we update CLI is as expected, and hence this PR.Checklist